After changing a bit the map above to check sth about Wraiths, I found another big bug (see 3rd VCMI Tests map):

#16 - 2nd Wait command on a creature during a turn is handled badly.

To reproduce:

• Load 3rd VCMI Tests map attached and attack with Septienna
• Watch the 6 funny regeneration animations at battle start (if you don’t get 6 like me, then it gets even more interesting as further investigation is needed)
• Wait on Bone Dragon & Black Knight
• Attack Wraiths (which meanwhile came close) with your Wraith & Wight, then move Walking Dead
• Wait on Black Knight, then Wait on Bone Dragon, Wait on Bone Dragon, Wait on Bone Dragon, Wait on Bone Dragon, Wait on Bone Dragon,… (if you reproduce it, you’ll see what I mean)
• Then move Bone Dragon 1 hex, and watch it remain stuck in flying animation, while the Wraiths fly in and attack it (this being the 2nd part of the bug).

Hopefully all the above are easily reproducible. This could be related to the #10 Wait+Cast bug reported above.
3rd VCMI Tests.7z (9.9 KB)

There is a critical bug in AI that makes impossible to end the turn.
(My fault, I’ve incompetently tried to block its adventurous part.)
To avoid this problem, please put this file into you AI/ subfolder: download.antypika.aplus.pl/GeniusAI.dll
I’ve also updated the package on the server, so if you downloaded build after this post was published, you don’t have to do anything.

Sorry for trouble.

Yep. That was it. The more I play, the more I run into more situations like this:

http://i4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/090920_KeyToVictory.jpg [size=75](after hero just picked up a resource pile in front of the wood)[/size]

We have a “leftover” of bug 0.71b#25 (pain sound in battle after game load). As its behavior has been restricted and the SourceForge item closed as fixed, I’m gonna raise it as new bug:

#17 - After game load, we have the same pain sound in battles after the casting of any damage spell.

and in general:

#18 - After game load, it seems we lose all creature sounds during battles (moving, attacking…)

#19 - In Hero Meeting window, when we click on the Catapult, it should give the pop-up saying “This item can’t be traded.” In 0.73c we get the same info pop-up that we would get in the Hero screen: “The Catapult must be equipped.”

#20 - War Machines can’t be exchanged yet (this sounds familiar, so apologies if it was already reported)

#21 - There is small delay in passing an artifact from one hero to another, in the sense that it first appears in the new slot and only a moment later it actually disappears from the original slot. And it has the same effect on the related bonuses. E.g.: in any of the VCMI_Tests maps attached above, take Sir Mullich to meet with Neela. And have him pass the Badge of Courage to her. You’ll see she gets it immediately, together with the morale bonus, but only half a second later the badge icon disappears from Sir Mullich’s slot, together with the morale bonus.

#22 - Closing Main Menu client from the upper right window button or with Alt+F4 leads to a crash:

i4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/th_2009-09-21_ClosingMainMenu.jpg

Crash logs attached:
2009-09-21_ClosingMainMenu.7z (79.7 KB)

Fixed.

Fixed.

SO ! BUGS in 73c :::::

#23-SERIOUS if u move horse/boat cursor out of map(broun textured field) and click - game crashes - it could be a pathfinder outofrange wrong check (i`ve checked with 73 - no such problem, so probably a cursor-implementation bug)
#24 very wrong estimated damage in battle - 4 titans - 16-32est and vs 6harpies done 446 dam, 6 archers - 117-176est and done 13 dam vs 6 harpies second round - 4 titans - vs harpies - 15-30 est and done 476dam 49gargoyles vs harpies 0-0 est !!!
#25 wrong creature fight order - now in siege - first round catapult had no turn(or it could be it’s the last one - speed 0, however in H3 it shoots before all creatures) and first turn was gargoyles’ and second - titans’ : in queue is shown - second round - first(or last in 1st round) - catapult then titans then gargoyles, but when it started all was again like in 1st round
#26 probably not yet implemented - Native Terrain(NT) in siege - gives bonuses for creatures to which NT of town is native(ie centaurs get bonuses when fighting in Castle siege) and this hapens irregardless where the town is located - rampart on swamp land in siege will have grass: my siege vs necropolis was not on dirt (necro NT) and necro creatures haven’t bonuses , but castle creatures had bonus when was a siege of Castle which was staying(trigger yellow point) on grass
#27 AI doesn’t evaluates wall in siege and melee fighters just stand in castle, but it is not yet implemented, i feel

#28 Map scrolling not working anymore if hero is selected. CTRL+Arrows move hero should scroll the adv. map. In 073 was ok.
If town is selected it works but very strange. (once I got crash but without dmp file).

#29 Refer to sound problems. There is also problem when you push NEW GAME, after first start it has long pause an multiple sound effects, other time is ok, and other there is no sound at all. *

*[size=75]I added a log number, because from your description it seems to be different than previous sound related bugs. When uncertain, I guess it’s safer to give a log number. Better to have a dupe than not to have a tracing log #.

Zamolxis[/size]**

That fix is both in the package and include Wights. It just does not include animation (it prevent only from adding health points, I haven’t tested it before claiming the success because the fix was very small, obvious and seemed to be enough [additional condition for being alive before applying regeneration]). Now it’s fully fixed.

Probably fixed (damage was calculated for different stacks), or at least more accurate. If it reoccurs in future releases, please re-report.

#30 Game crashes when attacking Creature Bank. Debugger points BattleQueue.

pos.h = bg->h;

EDIT: Actually it happens also when engaging neutral stack, so I guess the problem may be general.

#31 Pathfinder can’t find a way if the road is blocked by Event. Previously it did.

#32 IMP CACHE BUGS:

• imps do not attack gnolls
• quantity of units is wrong placed, unreadable i.e. it looks like imps were 30 and gnoll was 1 but it is inversely.
  img27.imageshack.us/img27/2827/bugimpcacheimpnotattack.th.jpg
• endless wait - if there left last two units before next round the wait can be used infinitely
  see below screenshot - last two stacks: gnol (1) and serpent fly (1) can be switched infinitely.
  img30.imageshack.us/img30/2517/bugimpcacheendlesswaiti.th.jpg img198.imageshack.us/img198/2517/bugimpcacheendlesswaiti.th.jpg

#33 - The Capitol of the conquered town is not destroyed if we already have one.

This is also related to 0.72#2 - Multiple Capitols allowed if set up from MapEditor. As H3 had the “1 Capitol per player” rule, I’ve posted some suggestions on how to handle possible fixes for both 0.72#2 & 0.73c#32 HERE.

On the other hand, I strongly support keeping the possibility of having more Capitols (through conquering or Map Editor) as a mod because, well, I could always use more money…

The Imps not attacking Gnolls may or may not be related to a bug reported some time ago, regarding AI not attacking the creature placed just in front of it (though I can’t find that report right now). To be investigated - and we can keep this 0.73c#32 referring mainly to that.

The other two are however general, and it would be nice if they can be solved soon (one because it’s pending for quite some time, and the other because it’s kind of annoying and was introduced only now with 0.73c):

• Quantity of units wrong placed / unreadable. This was reported long ago as 0.7#71 and is now the oldest logged item in SourceForge. I’ve posted a detailed description of how these stack boxes should be displayed at the bottom of my post HERE.

• Endless wait. This must be strongly related to 0.73c#16. I guess you just discovered a loop between 2 creatures of the same speed, while I had it only for 1 creature. That means it impacts all of the same highest speed creatures from our army.

oh what i’ve seeeeeeen now !!

started 1600*1200 but it was real pain slowdown, strange but i wrote (like i feeled this !!) before this game to “Miss_func” topic about probability switching off the animation on map and in town - creature and building to have better speed, and maybe due to this slowdown i got “bugs”

in the battle i’ve seen second animation starts before first - so read attentive - 2 stacks of enemy harpies and pikeman stack and archers - order - harpy, harpy,pikmen,archer,harpy,harpy
animation: …archer shoots - pikemen and harpies show pain animation at same time, then harpy beats pikemen, then pikemen beats(counter-) harpy and right after shows pain animation(2nd harpy attacked him) and then 2nd harpy shows attacking animation - that’s a SLOWDOWN - please try 1600*1200 arrogance3 attack with orrin lorelei - U will see heroes like RTS

and bug - #34 completely can’t see morale animation and no delay either - and those ai creatures who had morale just moving twice further - it quite fears ))

looking at the code I think you get bg a NULL, as new releases (before 0.73c?) was doing things with battlequeye giving posssibility to fields to be NULL and not all checks were done

Gaaa! My first bugfix. Actually a brand new feature of building demolition 8)

Also, only first town of player will keep its Capitol after game start - you can see it easily on Arrogance3.

#35 Bug with heroes in tavern - see attached save. In tavern on the right there is Sir.Mullich and if you buy only heroes from the left side there are all the time elementalist and planeswalkers. Isn’t it correctly implemented? I didn’t noticed that before
games.zip (222 KB)

Regarding #35, I also noticed we get Conflux heroes more often than usual. For example, when loading the VCMI_Tests map attached to some of my reports in this thread, I am always getting at least 1 Tavern hero from Conflux, and quite often both of them.

I wanted to run some more tests to make sure it’s not just a coincidence, but then I ended up running into bigger bugs that needed reporting and forgot about this (so I’m happy Boulie brought it up).

fixed

bug with lightning bolt animation was not related to resolution

Most probably fixed as bug #9 also caused quite severe damage to the rest of battle. After casting lightning bolt a very important variable was broken.

That’s strange. For me the melee defenders always go towards the gate (which by the way seems to not be implemented yet, as seen in the screenshot below; but I guess you knew that so no need to report it as bug just yet:).

I did however spot some other issues:

VCMI: http://i4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/2009-09-23_HeroBehindWallNoGate.jpg vs H3: http://i4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/2009-09-24_H3Siege.jpg

#36 - The upper wall goes over the hero and whatever creatures the defending army may have in the hexes from the upper row.

#37 - The visiting hero does not collect the best troops from garrison to fill in his empty army slots when the town is under siege.

#38 - The castle/central tower in VCMI is placed higher than in H3 (though if you look at the base, somehow the VCMI one seems more centered - Unfortunately I forgot to capture that in the shots, but you can see for yourself by loading the attached map in both VCMI & H3). So from my part this does not need to change, as the central tower looks now somehow better placed… I’m just not sure of it so I thought it’s best to report it.

#39 - The hero is placed lower on the battlefield as compared to H3 (look at the hooves of hero’s horse in the 2 screenshots). This has actually nothing to do with sieges in particular. It seems to be general for any battlefield, for both the friendly and the enemy hero (I just didn’t notice it before).

See the attached map to reproduce all of the above (for Inferno, not sure if valid for all towns, but probably yes).

#40 - Creature hit by Arrow Towers turns with the back towards the attack. It’s best noticeable if the first creature that moves after Arrow Towers is an enemy one. In this case, as seen below, our Sprite remained blocked turned in the opposite direction, from the moment they were hit by the Arrow Towers, until the Griffins finished their flight and it was our turn. You can use the attached map to reproduce it, if you first remove the purple visiting hero from the MapEditor so that you can fight the Garrison creatures (or else fix #37 so that the defending hero accepts the Garrison creatures in his army:).

And just for fun, check out also the upper tower gog peeking outside of the battlefield if I disable stack queue (result of bug #5):

i4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/th_2009-09-24_ShySprite.jpg
4th VCMI Tests.7z (9.95 KB)

Yeap , you’re right other time they were moving, so this wasn’t reproducible, but that time enemy skeletons were staying for about 3 rounds “in the wall” not going to gate

and about #34 - it was for ai creatures and on 16001200 so probably related to “slowdowns” because later I had morale on my troops on 800600