Problems building from svn on linux

International board Development
#15

Good find, thanks.

Ok.

With VS 2012 unordered container should work fine.

Uhm… I’m not sure what have you meant here.

Good. On the Windows side we can safely drop Visual 2010. All developers I know of use Visual 2012.

Unfortunately Microsoft failed to deliver more C++11 for VC11, so going for GCC 4.6 and VC 2012 gives us only:

  • nullptr
  • range-based for loop (we should run find&replace for all BOOST_FOREACH)
  • strongly typed enums and forward declarations for them

Still nice to have, should simplify some code.

Microsoft will release preview version of Visual 2013 (they say they expect it to be “production quality” but I’d take that declarations with a grain of salt) with more C++11 within a few days. I’m pretty eager to kill VS 2012 relatively soon, if that gets me uniform initialization, variadic templates and so on.

So to sum up:
Prefer Boost.Thread, Boost.Regex and boost::begin/boost::end. Otherwise std constructs should be prefered when available. Am I correct?

#16

Just rechecked and it seems to work at least with my versions of gcc/stdlibc++. So it looks like this is not a problem anymore

What I’ve been talking about is code like this:

std::map<int, std::unique_ptr<int>> container;
container.insert(std::make_pair(3, std::unique_ptr<int>(new int(10))));

With C++03 this would create copy of pair to insert. But unique_ptr can’t be copy-constructed resulting in compile error.

With C++11 insert can move element into container and containers have “emplace” method for in-place construction. Previously neither of these two methods were available in gcc.

Looks to be so.
Not sure on begin/end. They’re available in gcc-4.6 but implementation status says that they should not be present. Outdated documentation?

BTW: found some differences between boost::bind and std::bind:

  1. Unlike boost::bind overloaded functions can’t be resolved - you need to specify full function signature in std::bind. Does not adds to readability but can be avoided by 1-line lambdas or by removing overload.

  2. std::bind does not have overloads for compatison operators. Something like this no longer works with std::bind:

std::bind(&CTradeableItem::serial, _1) == selected->serial
#17

First part committed. Currently still compatible with gcc 4.5 and (presumably) VS 2010.

Unless there will be objections in a few days I’ll commit second part with stuff that will break older compilers:

  • switch to std::unordered containers
  • c++11 foreach
  • std::begin/end (if it will work correctly in gcc 4.6)
#18

gcc-4.6

#19

Looks like I forgot about disabled by default ERM. Will fix soon.

#20

Hi. Still fails on OpenBSD (revision 3431) with the same error:

  8%] Building CXX object lib/CMakeFiles/vcmi.dir/logging/CLogger.cpp.o
cd /usr/ports/pobj/vcmi-0.93/build-amd64/lib && /usr/ports/pobj/vcmi-0.93/bin/c++   -DM_BIN_DIR=\"/usr/local/bin\" -DM_DATA_DIR=\"/usr/local/share/vcmi\" -DM_LIB_DIR=\"/usr/local/lib/vcmi\" -Dvcmi_EXPORTS -pthread -std=c++0x -Wall -Wextra -Wpointer-arith -Wno-switch -Wno-sign-compare -Wno-unused-parameter -Wno-overloaded-virtual -DNDEBUG -fPIC -I/usr/ports/pobj/vcmi-0.93/vcmi-0.93 -I/usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib -I/usr/local/include -I/usr/local/include/SDL    -o CMakeFiles/vcmi.dir/logging/CLogger.cpp.o -c /usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/logging/CLogger.cpp
In file included from /usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/list:64:0,
                 from /usr/local/include/boost/algorithm/string/std/list_traits.hpp:15,
                 from /usr/local/include/boost/algorithm/string/std_containers_traits.hpp:20,
                 from /usr/local/include/boost/algorithm/string.hpp:18,
                 from /usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/../Global.h:98,
                 from /usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/StdInc.h:3,
                 from /usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/logging/CLogger.cpp:1:
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h: In constructor 'std::_List_node<_Tp>::_List_node(_Args&& ...) [with _Args = {const std::unique_ptr<ILogTarget>&}, _Tp = std::unique_ptr<ILogTarget>]':
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/ext/new_allocator.h:114:4:   instantiated from 'void __gnu_cxx::new_allocator<_Tp>::construct(__gnu_cxx::new_allocator<_Tp>::pointer, _Args&& ...) [with _Args = {const std::unique_ptr<ILogTarget>&}, _Tp = std::_List_node<std::unique_ptr<ILogTarget> >, __gnu_cxx::new_allocator<_Tp>::pointer = std::_List_node<std::unique_ptr<ILogTarget> >*]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:494:8:   instantiated from 'std::list<_Tp, _Alloc>::_Node* std::list<_Tp, _Alloc>::_M_create_node(_Args&& ...) [with _Args = {const std::unique_ptr<ILogTarget>&}, _Tp = std::unique_ptr<ILogTarget>, _Alloc = std::allocator<std::unique_ptr<ILogTarget> >, std::list<_Tp, _Alloc>::_Node = std::_List_node<std::unique_ptr<ILogTarget> >]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:1523:63:   instantiated from 'void std::list<_Tp, _Alloc>::_M_insert(std::list<_Tp, _Alloc>::iterator, _Args&& ...) [with _Args = {const std::unique_ptr<ILogTarget>&}, _Tp = std::unique_ptr<ILogTarget>, _Alloc = std::allocator<std::unique_ptr<ILogTarget> >, std::list<_Tp, _Alloc>::iterator = std::_List_iterator<std::unique_ptr<ILogTarget> >]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:988:9:   instantiated from 'void std::list<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = std::unique_ptr<ILogTarget>, _Alloc = std::allocator<std::unique_ptr<ILogTarget> >, std::list<_Tp, _Alloc>::value_type = std::unique_ptr<ILogTarget>]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:1456:6:   instantiated from 'void std::list<_Tp, _Alloc>::_M_initialize_dispatch(_InputIterator, _InputIterator, std::__false_type) [with _InputIterator = std::_List_const_iterator<std::unique_ptr<ILogTarget> >, _Tp = std::unique_ptr<ILogTarget>, _Alloc = std::allocator<std::unique_ptr<ILogTarget> >]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:573:9:   instantiated from 'std::list<_Tp, _Alloc>::list(const std::list<_Tp, _Alloc>&) [with _Tp = std::unique_ptr<ILogTarget>, _Alloc = std::allocator<std::unique_ptr<ILogTarget> >, std::list<_Tp, _Alloc> = std::list<std::unique_ptr<ILogTarget> >]'
/usr/local/include/boost/foreach.hpp:575:9:   instantiated from 'boost::foreach_detail_::simple_variant<T>::simple_variant(const T&) [with T = std::list<std::unique_ptr<ILogTarget> >]'
/usr/local/include/boost/foreach.hpp:652:95:   instantiated from 'boost::foreach_detail_::auto_any<boost::foreach_detail_::simple_variant<T> > boost::foreach_detail_::contain(const T&, bool*) [with T = std::list<std::unique_ptr<ILogTarget> >]'
/usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/logging/CLogger.cpp:200:3:   instantiated from here
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/stl_list.h:113:71: error: use of deleted function 'std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = ILogTarget, _Dp = std::default_delete<ILogTarget>, std::unique_ptr<_Tp, _Dp> = std::unique_ptr<ILogTarget>]'
/usr/local/lib/gcc/x86_64-unknown-openbsd5.3/4.6.3/../../../../include/c++/4.6.3/bits/unique_ptr.h:256:7: error: declared here
/usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/logging/CLogger.cpp: In member function 'EConsoleTextColor::EConsoleTextColor CColorMapping::getColorFor(const CLoggerDomain&, ELogLevel::ELogLevel) const':
/usr/ports/pobj/vcmi-0.93/vcmi-0.93/lib/logging/CLogger.cpp:379:1: warning: control reaches end of non-void function -Wreturn-type]
*** Error 1 in . (lib/CMakeFiles/vcmi.dir/build.make:289 'lib/CMakeFiles/vcmi.dir/logging/CLogger.cpp.o')
*** Error 1 in . (CMakeFiles/Makefile2:79 'lib/CMakeFiles/vcmi.dir/all')
*** Error 1 in /usr/ports/pobj/vcmi-0.93/build-amd64 (Makefile:137 'all')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2648 '/usr/ports/pobj/vcmi-0.93/build-amd64/.build_done')
*** Error 1 in /usr/home/kirby/mystuff/games/vcmi (/usr/ports/infrastructure/mk/bsd.port.mk:2372 'all')
d5.3/4.6.3/../../../../include/c++/4.6.3/bits/unique_ptr.h
#21

That’s weird. It works for me with same compiler and I don’t see what may be wrong here. Different boost version?

Try this:
Open file lib/logging/CLogger.cpp, line 200 and replace current code:

BOOST_FOREACH(auto & target, logger->targets)

with this:

for (auto & target : logger->targets)

OR if this will not help try this:
File lib/logging/CLogger.h, line 119
Replace this:

std::list<unique_ptr<ILogTarget> > targets;

With this:

std::vector<unique_ptr<ILogTarget> > targets;
#22

The fist one helped. But after that I have to change OVERRIDE -> override in next files:
server/CQuery.h
lib/CThreadHelper.cpp
lib/CObstacleInstance.h
At least it compiled. I’ll try to play with it today.

#23

Damn… Sorry for the noise. All problems were solved by updating system and gcc.

#24

Revision 3432

 98%] Building CXX object test/CMakeFiles/vcmitest.dir/CMapEditManagerTest.cpp.o
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp: In member function ‘void CMapEditManager_DrawTerrain_View::test_method()’:
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:95:17: error: expected primary-expression before ‘const’
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:95:48: error: ‘BOOST_FOREACH’ was not declared in this scope
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:96:3: error: expected ‘;’ before ‘{’ token
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:91:8: warning: unused variable ‘editManager’ -Wunused-variable]
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘}’ at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘catch’ at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘(’ at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected type-specifier at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘)’ at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘{’ at end of input
/mnt/another/tmp/vcmi/test/CMapEditManagerTest.cpp:139:1: error: expected ‘}’ at end of input
/usr/include/boost-1_49/boost/system/error_code.hpp: At global scope:
/usr/include/boost-1_49/boost/system/error_code.hpp:214:36: warning: ‘boost::system::posix_category’ defined but not used -Wunused-variable]
/usr/include/boost-1_49/boost/system/error_code.hpp:215:36: warning: ‘boost::system::errno_ecat’ defined but not used -Wunused-variable]
/usr/include/boost-1_49/boost/system/error_code.hpp:216:36: warning: ‘boost::system::native_ecat’ defined but not used -Wunused-variable]
make[2]: *** [test/CMakeFiles/vcmitest.dir/CMapEditManagerTest.cpp.o] Error 1
make[1]: *** [test/CMakeFiles/vcmitest.dir/all] Error 2
make: *** [all] Error 2
#25

Revision 3433:

 65%] Building CXX object AI/FuzzyLite/CMakeFiles/FuzzyLite_lib.dir/AreaCentroidAlgorithm.cpp.o
In file included from /mnt/another/tmp/vcmi/AI/FuzzyLite/LinguisticTerm.h:29:0,
                 from /mnt/another/tmp/vcmi/AI/FuzzyLite/AreaCentroidAlgorithm.cpp:18:
/mnt/another/tmp/vcmi/AI/FuzzyLite/defs.h:40:0: warning: "isnan" redefined [enabled by default]
/usr/include/math.h:259:0: note: this is the location of the previous definition
/mnt/another/tmp/vcmi/AI/FuzzyLite/defs.h:41:32: error: expected unqualified-id before 'sizeof'
/mnt/another/tmp/vcmi/AI/FuzzyLite/defs.h:41:32: error: expected ')' before 'sizeof'
make[2]: *** [AI/FuzzyLite/CMakeFiles/FuzzyLite_lib.dir/AreaCentroidAlgorithm.cpp.o] Error 1
make[1]: *** [AI/FuzzyLite/CMakeFiles/FuzzyLite_lib.dir/all] Error 2
make: *** [all] Error 2
#26

Sorry for this, please try r3434.

#27

I had to revert std::bind to boost::bind (r3435). It worked in most cases… but there was a number of uses that was making VS 2012 compiler go mad. Seems to be VS2012-specific bug because the same code works fine with VS 2013 Preview.

I haven’t checked in detail what is the exact cause — if std::bind does not reliably work, we need to stick with boost::bind. At least till we support VS 2012.

#28

There is still [forum.vcmi.eu/t/problems-building-from-svn-on-linux/686/24) error.

#29

I don’t know what’s wrong there, the project can be excluded from the build (it contains just the tests for map edit manager).

Please try replacing BOOST_FOREACH(a, b) with for(a : b). If it won’t help, at least we might get better error message.

#30

Yep, that fixes the error.

#31

Sorry it’s not related, I’m posting here because I’m not a member yet and cannot open a new thread. It would be great if the game could go with any version of boost without insisting on a specific build. For example yesterday I upgraded to Fedora 19 and now instead of boost 1.50 I have 1.53 and the game won’t start. I tried to cheat it by making symlinks but it recognised the wrong version, but I believe there is no reason to require a certain version, as long as boost exists on the system. Am I wrong? I’ve used to compile the game from source, but why should I do it if I have a package (me? lazy? naaa). So, is there a way to trick the game without recompiling it or waiting for the next release? Thank you!!

#32

When it comes to such libraries like boost even minor difference in version may end badly. So no - vcmi compiled with boost 1.50 must use 1.50 in runtime.

This restriction was not made by us but rather by compiler and boost library.

However at least Ubuntu supports installation of multiple versions of boost at once. For example right now I have installed package “boost1.46” as well as “boost1.48”. This may not be applicable to Fedora but such possibility exists.

#33

Rev 3440:

#34

Oh bummer :frowning:
Hmm yes it’s possible with yum to install a newer version of a package, and it will co-exist with the older version as long as the exact version number is specified and ‘yum update’ hasn’t run yet.

I’m afraid it won’t help in the case of fedora, because its release cycle overlaps with vcmi’s cycle, and the wanted version is always the one that came with the previous release (and it’s usually a bad idea to mix dependencies from different releases).

So next time I’ll be less hasty and stick with the current release a bit longer to enjoy vcmi :slight_smile: (too lazy to switch a distro, I have a reputation to maintain after all)