Crash on selecting "Single Scenario"

Siegfried · February 9, 2023, 11:05am

Next crash. I started the launcher, then the game, then new game, then single scenario. This made the server crash.

Console log:

Trying connection to 127.0.0.1:3030(0)
Problem with connecting: Connection refused
Something went wrong... checking for error info
Connection refused
Server command line: /usr/games/vcmiserver --port=3030 --run-by-client --uuid=1ecdec74-8f82-41c0-8cc0-648226241442 --enable-shm > "/home/siegfried/.cache/vcmi/server_log.txt"
Unrecognized bonus name! (DAEMON_SUMMONING)
Establishing connection...
Found endpoints:
	0:127.0.0.1:3030
Trying connection to 127.0.0.1:3030(0)
Established connection with VCMI 1.2.0.GITDIR-NOTFOUND (server). UUID: 2c2dbd69-a937-437a-8b5f-1a8d0269080b
map::at
terminate called after throwing an instance of 'std::out_of_range'
  what():  map::at
Network error receiving a pack. Connection Connection with VCMI 1.2.0.GITDIR-NOTFOUND (server) (ID: 1 UUID: 1ecdec74-8f82-41c0-8cc0-648226241442) dies. What happened: read_some: Connection reset by peer

Only active and existing mod: vcmi-extras.
End of server log:

[2023-Feb-09 12:01:27.459648] INFO mod - 	Handlers post-load finalization: 6 ms 
[2023-Feb-09 12:01:27.459662] INFO mod - 	All game content loaded in 253 ms
[2023-Feb-09 12:01:27.459859] TRACE network - CVCMIServer created! UUID: bf9430f5-9a27-403c-8deb-96b00303040a
[2023-Feb-09 12:01:27.459914] INFO network - Port 3030 will be used
[2023-Feb-09 12:01:27.459955] INFO network - Listening for connections at port 3030
[2023-Feb-09 12:01:27.510273] INFO network - We got a new connection! :)
[2023-Feb-09 12:01:27.511353] INFO network - Established connection with VCMI 1.2.0.GITDIR-NOTFOUND (client). UUID: b650bcb8-f7e0-4352-b2f2-7a735dccc773
[2023-Feb-09 12:01:27.511714] TRACE network - Received CPack of type 20LobbyClientConnected
[2023-Feb-09 12:01:27.511733] INFO network - Connection with client 1 established. UUID: bf9430f5-9a27-403c-8deb-96b00303040a
[2023-Feb-09 12:01:27.511758] INFO network - Client 1 player: Player
[2023-Feb-09 12:01:27.511780] INFO network - system says: Player (pid  cid 1) joins the game
[2023-Feb-09 12:01:27.561590] TRACE network - Sending a pack of type 20LobbyClientConnected
[2023-Feb-09 12:01:27.561715] TRACE network - Sending a pack of type 16LobbyUpdateState
[2023-Feb-09 12:01:28.686245] ERROR network - Network error receiving a pack. Connection Connection with VCMI 1.2.0.GITDIR-NOTFOUND (server) (ID: 1 UUID: b650bcb8-f7e0-4352-b2f2-7a735dccc773) dies. What happened: read_some: Connection reset by peer
[2023-Feb-09 12:01:28.686341] INFO network - Thread listening for Connection with VCMI 1.2.0.GITDIR-NOTFOUND (server) (ID: 1 UUID: b650bcb8-f7e0-4352-b2f2-7a735dccc773) ended
[2023-Feb-09 12:01:28.713433] INFO network - Thread handling connections ended

misiokles · February 9, 2023, 11:36am

Disable Extended RNG Option (submod of vcmi-extras).

Siegfried · February 9, 2023, 3:01pm

Works. Thanks.

Two more bugs:

I tried one of the campaigns. Finished the first scenario. Then, on advancing to the next scenario, i did a mouseclick during the intro. Now instead of starting that nexr scenario, i got the custom campaign selection dialogue. Tried 3 times.
I added ma mod and tried a test map. Visited a university with a cleric and with a knight. The university offered one of my new skills. But for the cleric as well as for the knight this skill was in red (disallowed).

Setup for this skill is:

	"geology" : {
		"name" : "Geology",
		"gainChance" : {
			"might" : 7,
			"magic" : 1
		},
		"basic" : {
			"images" : {
				"small" : "skills/GemsSmall1.png",
				"medium" : "skills/GemsMedium1.png",
				"large" : "skills/GemsLarge1.png"
			},
			"description" : "{Basic Geologist}\n\ngenerates 1 gem per day.",
			"effects" : {
				"main" : {
					"type" : "GENERATE_RESOURCE",
					"subtype" : "resource.gems",
					"val" : 1
				}
			}
		},
...

And in heroClasses.json:

	"core:knight" :
	{
		"secondarySkills" : {
			"nobility" : 10,
			"gating" : 0,
			"mummification" : 0,
			"geology" : 5,
		}
	},
	"core:cleric" :
	{
		"secondarySkills" : {
			"nobility" : 10,
			"gating" : 0,
			"mummification" : 0,
			"geology" : 5,
		}
	},

That already worked with older versions of vcmi. This is a new bug.
Edit: Tried again, got two other of my new skills.
err02
Disabling Gating for Knight is ok, but alchemy should be possible. Seems any of the new skills is disabled for any kind of hero.

kambala · February 9, 2023, 4:50pm

known bug: Bug in the campaign when switching to the second mission (develop) · Issue #1510 · vcmi/vcmi · GitHub

Siegfried · February 9, 2023, 4:58pm

Ah, ok. So this will be fixed some day.

misiokles · February 9, 2023, 6:09pm

Maybe problem with hero classes are related to this?

Bug was fixed for map editor, but not included in daily builds yet, I guess.

Siegfried · February 10, 2023, 10:51am

Not sure, not enough info there. But seems to be plausible.
The bug is new. V0.99 did not have it, and as far as i remember, V1.0 and v1.1 did not have it either. This is a 1.2 issue, which currently is not stable.

Edit: I just tested again. I levelled a Ranger and he got one of my new resource skills offered. So this bug is limited to the Univertity.

Ivan · February 10, 2023, 3:41pm

No, that bug is strictly map editor related.

Any easy way to reproduce it? Can you upload your mod or suggest another mod that also has bugged secondary skills?

Siegfried · February 10, 2023, 3:49pm

I could upload my mod. Question is just: Where? In a few days i’ll have an address to upload to. So if you have a few days

kambala · February 11, 2023, 6:58am

you could simply upload zip to dropbox / google drive / etc.

Siegfried · February 16, 2023, 2:41pm

I’m currently trying 4shared. At least i succeeded in uploading a map.

It seems i now succeeded in uploading my mod too. Mod is not finished. still much to to

Siegfried · February 16, 2023, 3:45pm

The server crashes with this map. It took me some time to find what is the cause. Here it is:

As far as i remember, many of those decorative objects use this index. Mostly the Fred79 objects. These 3 ice objects where in my editor. Unfortunately i could not find all of them. So i added a line in the “generic.json” file:

	/// Decorations
	"decorativeObject"					: { "index" :40, "handler": "static", "types" : { "object" : { "index" : 0} } },
	"cactus"						: { "index" :116, "handler": "static", "types" : { "object" : { "index" : 0} } },

I added the line before the “cactus”. Now the map starts.
Better would be: If the vcmi engine (server) detects an unknown object, just remove it (instead of simply crash).

misiokles · February 16, 2023, 6:01pm

Your code can be written better, for example "core:cactus" so game knows automatically what index cactus has and then you don’t need to copy “index” parameter or even handlers. You can compare code in ‘hota decorations’ submod.

misiokles · February 16, 2023, 6:02pm

Link is empty.
Better to upload to mediafire.com

Siegfried · February 16, 2023, 6:10pm

core:cactus

No, i added this line to the core file. Index is not allowed in mods.

If anyone wants to play that map without this line added, please remove all those ice objects. I tried already, but obviously did not find all.

Siegfried · February 16, 2023, 6:18pm

Ok, tried mediafire.

Map: Test
Mod: special mod

misiokles · February 16, 2023, 6:27pm

Downloaded!

Siegfried · February 16, 2023, 6:28pm

Good luck

Edit: Just for completeness i added the other mod, which allows up to 32 heroes while still does not touch the number of adventuring heroes. It’s just a very small mod.

MaxiMaps

Siegfried · February 18, 2023, 12:10pm

Another crash. Same as i had a few days ago. The serv er crashed on visiting a lighthouse. Server log:

[2023-Feb-18 13:01:09.248080] DEBUG global - Hero hero.special.ariel.name visits Lighthouse (42:0)
[2023-Feb-18 13:01:09.248093] TRACE global - Created a new query with id 5009
[2023-Feb-18 13:01:09.248103] TRACE network - 	Sending to all clients: 9HeroVisit
[2023-Feb-18 13:01:09.248114] TRACE network - Sending a pack of type 9HeroVisit
[2023-Feb-18 13:01:09.248139] TRACE network - 	Applied on gs: 9HeroVisit
[2023-Feb-18 13:01:09.248144] TRACE network - 	Sending to all clients: 17SetObjectProperty
[2023-Feb-18 13:01:09.248148] TRACE network - Sending a pack of type 17SetObjectProperty
[2023-Feb-18 13:01:09.248167] TRACE network - 	Applied on gs: 17SetObjectProperty
[2023-Feb-18 13:01:09.248180] TRACE network - 	Sending to all clients: 10InfoWindow
[2023-Feb-18 13:01:09.248185] TRACE network - Sending a pack of type 10InfoWindow
[2023-Feb-18 13:01:09.248206] TRACE network - 	Applied on gs: 10InfoWindow
[2023-Feb-18 13:01:09.248211] TRACE network - 	Sending to all clients: 9GiveBonus
[2023-Feb-18 13:01:09.248215] TRACE network - Sending a pack of type 9GiveBonus
[2023-Feb-18 13:01:09.252089] ERROR global - Error: signal 11 :
[2023-Feb-18 13:01:09.256136] ERROR global - /usr/games/vcmiserver(+0xe9ea2) [0x55e19a858ea2]
[2023-Feb-18 13:01:09.256296] ERROR global - /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7f813c4c4520]
[2023-Feb-18 13:01:09.256389] ERROR global - /usr/lib/

The lighthouse visited was this one:
h3crash002
Nothing special about this lighthouse. The few days ago i visited this lighthouse with another hero. Same crash.

kambala · February 20, 2023, 8:56am

it was fixed a couple of days ago: merge conflict regression fix by nullkiller · Pull Request #1591 · vcmi/vcmi · GitHub