Also once we get new version I want owner of this one to get it unlisted: play.google.com/store/apps/deta … vcmi&hl=en
Or if he agrees he can transfer ownership too. Then we could update it once and suggest to install another app instead and then unlist it so it’s not confusing anyone.
Well, technically I am an android dev.
3rd party licenses definitely should be placed somewhere in the launcher.
Don’t know about policy, because vcmi doesn’t really do anything with user data – the only thing that could qualify is probably sdcard reading/writing.
Do you mean my changes in vcmi? Currently they’re here github.com/Fayth/vcmi/tree/android-support – I can start a pull request to vcmi/develop if that’s what you mean… probably not today though. I tried to wrap all android-specific logic in VCMI_ANDROID define so hopefully the won’t be any problems, but currently I don’t have any environment installed to check if the desktop version complies correctly.
Sure. I think it’s a good idea that vcmi team has the ownership over this.
If you feel that the current vcmi/develop version is stable enough to be published then there’s no problem on my side.
No technical problems. Only the fact that google suggests that your app’s id should reflect the domain that you own. But it’s not really a problem, because it’s not a hard rule, just a guideline.
No built-in mechanism. Usually apps just save previously launched version number and check it on startup.
In our case, we should probably try to detect datafiles in the old location and move them if possible. Should be doable.
Sadly this is something I have like zero idea about so all I can do is just google it.
Just create pull request and Travis will compile it.
We’ll also be able to find if there something need to be fixed.
Welcome to team! If seriously we obviously not give everyone access to main repository since not everyone actually need them, but I think github have teams inside organizations so there no problem to invite you and then let you control repositories you want and non-develop branch.
Warmonger / AVS might need comment on this though since I don’t have full permissions on github.
I don’t think it’s stable, but it’s far better than 0.97 for sure.
I think they forgive us. Or we could ask for ownership over other package later that in fact represent our domain.
VCMI Organization membership give no additional access, only Teams do and on repository level. There is no way to control access to individual branches
So for instance we can let Fay to keep Android-specific changes in main repository branch even without giving develop (protected branch) push access. Of course we can also just ask nicely to not push directly anything unless it’s absolutely obvious and tested fix.
I can look at the CI config after android support pull request is sorted out.
In theory it should be possible to automate the build without much problem (because it already works kinda automatically via the python script), but at the moment I’m not sure what I need to specify there. Anyway, I will check that out.
Okaaay, so after reading a bit about travis, I added an experimental config to lint.travis-ci.org/vcmi/vcmi-android says it’s syntactically valid, but I can’t really check anything more). travis-ci.org/vcmi/vcmi-android says that travis is not enabled for this repo so I think you need to turn it on manually to check?
Btw, android app on master should compile/work correctly on android 4.1+.
Okay, I tinkered with it for some time, but have to give up for today.
I think I’m past “obvious” errors already, because travis starts actual cmake build. Hopefully not much left until it builds correctly, because there errors are killing me.
Okay, I managed to detect the data path from previous version and migrate Data, Mp3, Saves and Maps folders and config/settings.json file. I decided to skip Mods folder though (I think it could cause problems aaand it would take more time to implement).
Edit ~ actually, the saves probably aren’t even compatible with current version, so probably they shouldn’t get migrated…
Feel free to mess with the travis file.
If you need it, generated artifacts should be in ./project/vcmi-app/build/outputs/apk/*.apk
There are still some (minor) things to solve for daily builds. Currently travis builds only one configuration (debug, api16+, armeabi-v7a). I think that ideally 2 packages should be created (release,api16,armeabi-v7a and release,api21,all abis). Changing the build to 2 packages is probably a matter of fiddling with travis config (+ less hardcoding in ./travis-extras/vcmiconf.json.in) and to build release package, we would need to add some “fake” signing to repo.