Few new things here, basically several fixes over previous build.
I tried to fix some library dependency issues. Please let me know if it works fine. I believe I have fixed all the issues reported in the previous package.
Please let me know if you consider this build good enough to release 0.95 on Feb 1st or should we postpone the main release.
Unfortunately I currently have hardly any time for fixes or new features. Nevertheless, if there is something I should take care of, please let me know.
sorry, if I will anger someone, but I think it’s better to delay build to make it more stable. At least for a week-two.
I don’t say it’s nstable, but for example “Restart map” leads to crash.
I will commit to SVN in a few hours. This update will include mostly bugfixes related to campaigns.
I’m relatively without passion if we should release on 1st february or one month later. One thing should be fixed nevertheless, VCMI crashes a lot when I start maps (campaign scenarios) or complete them and start another map. It always complains about some mutexes. I will create a mantis issue if I receive the next crash (they are unpredictable)
#1673 — I’ll check this later, maybe this weekend.
#1672 — It’s hard for me to correct a crash that is not reproducible.
Does #1672 indeed happens only when starting a new game? (ie. at the start of first turn)
At the game start there should be no path to display at all, and currentPath is (supposedly) initialized to nullptr.
Please check the variable values with debugger if that crash happens again.
It would be useful to see stacktraces of other threads as well.
I believe this has been fixed. Stupid bug, most likely has been present for years.
Apparently I needed some break from VCMI code to spot it.
**
Still, I think I won’t release 0.95 today. [unless both Ivan and Warmonger think I should ]
Too many crashes in campaigns to make it useful. More issues are appearing after loading the save.
There’ll most likely 0.94d later today or tomorrow. The release will be out on time, just we won’t give it a new number and the usual promotion.
Prefereably I’d like to have all campaigns went through with “vcmisilmaril” before the official release and in two variants — right from the start and with save/load in the middle.
Tow,
1st March then? OK for me although I don’t like that we have such long time between releases.
I’m wondering how many of these campaign crash reports we have on Mantis right now are actually duplicates - with current trunk I was able to complete 4 campaigns using vcmisilmaril without any crashes. Including campaigns mentioned in some of bug reports.
Povelitel, once next build is out can you recheck you reports related to crashes on starting a mission in campaign? I think all of these were caused by two bugs, both of which should be fixed now.
Also, I believe we may change release policy. Now it takes too long between things are fixed or added and they are tested.
I suggest releasing development build every month (roughly), after any significant part is added or remade.
I feel the same.
Still, given the current sorry state of engine, I don’t like releasing it as-is even more.
You are right. It is one of the problems. Would you be willing to prepare and release such development builds?
There other issues as well:
— there’s little point in making often releases, if we aren’t able to properly handle bugreports we receive. We have over 350 open issues. They should be given a priority in focus over adding new features. We must stabilize.
— trunk gets destabilized too often. Bigger features should be developed on branches, and code known to be wrong/half-done should not go to trunk.
— some attention should be given to the savegames compatibility. Perhaps we should defer integrating save-breaking changes by better use of branches.
SVN doesn’t work with branches that well. I guess we’ll need to switch to git if we want to introduce the branch-based approach. But I guess it’s not a topic for a discussion here.
Unfortunately I am occupied with work and I’m unable to keep a grip on all things as I have done before. I rarely review the committed code and I don’t test the state of engine on the regular basis. Somehow it seems that when I don’t look, the stability of the engine goes crumbling down. So please take initiative and remind me when I should to check a particular issue or take some other action. Still, I won’t do any major rewrites/features soon and you should not write any code assuming I’ll fix it or its dependencies.
]