Forum index VCMI Project - Heroes 3: WoG recreated
Forum of the project aiming to recreate best turn-based strategy ever!

FAQFAQ  SearchSearch  MemberlistMemberlist  UsergroupsUsergroups  StatisticsStatistics
RegisterRegister  Log inLog in  AlbumAlbum  DownloadDownload

Previous topic :: Next topic
[Archived] I want to help...
Author Message
Warmonger 
VCMI programmer


Age: 28
Joined: 07 Jun 2008
Posts: 1545
Location: Warsaw, Poland
Posted: 2010-10-25, 12:39   

I lied, CMapInfo is indeed missing. I was not able to find such a file in repository at all, so it must have been added recently.

What a mess...
_________________
Think twice if you really need to send me private message. Use public forum for general questions.
DJ Warmonger blog
beegee wrote:
Warmonger, you are the best!
 
 
     
Tow 
Project Lead
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1407
Location: Kraków, Poland
Posted: 2010-10-25, 17:08   

I've uploaded missing files, sorry for trouble.
_________________
VCMI is a work in progress.
VCMI is NOT an another mod.
 
     
Ozsy 

Age: 29
Joined: 25 Oct 2010
Posts: 4
Location: Szeged, Hungary
Posted: 2010-10-25, 18:17   

Thanks, both of you it's almost working now! I managed to compile all 4 projects (revision 1822), and link each except for the client. As far as I can tell, it misses the files of CMapHandler.
I managed to start the server, so I think it's the only thing left before I can ask: "How can I help?"

Edit:
I managed to find it, it's just called maphandler.cpp, the client is built succesfully.

Edit2:
The client is working, I managed to run 2 instances and start up a MP lobby :)

So, how can I help?
 
     
Warmonger 
VCMI programmer


Age: 28
Joined: 07 Jun 2008
Posts: 1545
Location: Warsaw, Poland
Posted: 2010-10-25, 19:06   

Just have a look
http://wiki.vcmi.eu/index.php?title=TODO_list

However, it's not a good moment to add new functionalities as old code is hardly working and needs fixes, though no one has time for that.
_________________
Think twice if you really need to send me private message. Use public forum for general questions.
DJ Warmonger blog
beegee wrote:
Warmonger, you are the best!
 
 
     
Tow dragon 
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1004
Location: Kraków
Posted: 2010-10-25, 19:28   

@Ozsy
+ @Warmonger

You can always take an older, stable revision and improve our AI. The interface does not change significantly over time so merging with trunk when it's more stable will be easy.

I don't recommend bugfixing for beginners as it's hard, not satisfying and time-consuming.
_________________
:)
 
     
Ozsy 

Age: 29
Joined: 25 Oct 2010
Posts: 4
Location: Szeged, Hungary
Posted: 2010-10-26, 16:43   

One more question: How much work should be done before updating the repository? I made some changes in BattleHelper (and a bit in BattleLogic).
 
     
Tow dragon 
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1004
Location: Kraków
Posted: 2010-10-26, 21:18   

Actually we don't have precise guidelines but:
1) the code in repository should always compile, especially trunk
2) don't commit more than 2 times a day if you don't think it really necessary
3) it's good when you don't break features that already worked, especially just before releases (but it's not obligatory in some cases)
4) don't commit unnecessary files (like Warmonger did in rev 1822); if you accidentally do, remove them once you see what happened
5) enjoy coding!
_________________
:)
 
     
Ozsy 

Age: 29
Joined: 25 Oct 2010
Posts: 4
Location: Szeged, Hungary
Posted: 2010-10-28, 20:52   

Next question: how can I get access to upload my files?
 
     
Tow 
Project Lead
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1407
Location: Kraków, Poland
Posted: 2010-10-29, 21:31   

You'd need to create an account at sourceforge. But to start with you can post your changes in patch/diff format here (or send them directly to me) and I'll upload them. :-)
_________________
VCMI is a work in progress.
VCMI is NOT an another mod.
 
     
exine 

Joined: 25 Jul 2011
Posts: 14
Posted: 2011-07-25, 21:27   

Little question. As I'm currently peeking at code in various locations and I found many commented out lines, are patches cleaning up those and improving readability accepted? I think it would help other people that will join project. Well, I can improve documentation, too.
 
     
Warmonger 
VCMI programmer


Age: 28
Joined: 07 Jun 2008
Posts: 1545
Location: Warsaw, Poland
Posted: 2011-07-26, 06:35   

Most commented-out parts indicate that some part of code was rewritted / improved. It's not necessary to remove them as long as they may be helpful if new code is wrong. These are usually removed by devs after few months, if they are sure this code won't be needed anymore.

I'm not sure if code clearing will help anyone join the project (it looks clear enough now IMO), but documentation certainly can. We have entire Wiki to be filled with technical details. Also, player's manual, entires and especially general info about the project are areas for improvement.
_________________
Think twice if you really need to send me private message. Use public forum for general questions.
DJ Warmonger blog
beegee wrote:
Warmonger, you are the best!
 
 
     
Guest
Guest
Posted: 2011-07-26, 07:02   

Warmonger, but if the new code is wrong you can always use version control system to "travel back in time" :-)
 
     
Tow dragon 
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1004
Location: Kraków
Posted: 2011-07-26, 16:38   

Guest wrote:
Warmonger, but if the new code is wrong you can always use version control system to "travel back in time"


Comment just above or just below is much easier to notice and to handle. SVN is really poor at browsing the history of changes of a function. If I had super-fast blame tool integrated with IDE with a sider for selecting last revision to take into account, then version control would be better than those comments indeed.
_________________
:)
 
     
exine 

Joined: 25 Jul 2011
Posts: 14
Posted: 2011-07-26, 20:08   

https://github.com/kot-behemoth/VCMI/blame/master/AI/GeniusAI/AIPriorities.cpp

Do you really still think that git or other distributed systems are worse? ;)

Well, if someone wants to check if sticking with "bullet-proof" SVN is better:

Mercurial intro: http://hgbook.red-bean.com/
Git intro: http://book.git-scm.com/

I personally use mercurial + HgSubversion extension for working with SVN repositories. I recommend trying that in spare time. Docs: http://mercurial.selenic.com/wiki/HgSubversion

About amount of dead code that can be removed: https://bitbucket.org/exine/vcmi-patches/src/tip/deadcode.patch
 
     
Tow dragon 
VCMI Programmer


Joined: 01 Feb 2008
Posts: 1004
Location: Kraków
Posted: 2011-07-27, 20:11   

exine wrote:
Do you really still think that git or other distributed systems are worse? ;)


No, I think they are better than centralized systems in principle. I'd really like to have a well-implemented distributed version system. Let me just write my recent experience with bazaar. I've cloned VCMI repository (without any problems) and ran blame tool on one of files (to be precise, not the command line tool but a graphical interface for it). It worked almost perfectly, was very fast and did everything that I wanted (including selection of last revision to be shown). There was just one small glitch: after selecting last revision some revision numbers were truncated to last three digits.

I don't write it as a complain nor bug report. I just want to point that DVCSes seem to be quite stable now but they still have some minor problems. Bazaar seems to be the best for my taste (non-hash revision numbering, good tools for Windows) and I can use it even without any changes in our main repository. It seems to be worth a try (I just need more time for VCMI).

exine wrote:
Docs: http://mercurial.selenic.com/wiki/HgSubversion


VCS in command line? Most Windows users are too afraid to use command line for tasks it suits better but some Linux users seem to go too far in the opposite direction.

Quote:
About amount of dead code that can be removed: https://bitbucket.org/exine/vcmi-patches/src/tip/deadcode.patch


I think that comments are not worth removing. What bad could happen if it stays there? And they may be helpful for those who don't browse the history of changes all the time.
_________________
:)
 
     
Display posts from previous:   
Reply to topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Add this topic to your bookmarks
Printable version

Jump to:  

Powered by phpBB modified by Przemo © 2003 phpBB Group

Hosting provided by DigitalOcean
Page generated in 0.03 second. SQL queries: 13