Forum index VCMI Project - Heroes 3: WoG recreated
Forum of the project aiming to recreate best turn-based strategy ever!

FAQFAQ  SearchSearch  MemberlistMemberlist  UsergroupsUsergroups  StatisticsStatistics
RegisterRegister  Log inLog in  AlbumAlbum  DownloadDownload

Previous topic :: Next topic
Git hub Pull request question
Author Message
krs


Joined: 04 Sep 2012
Posts: 374
Posted: 2017-01-28, 20:16   Git hub Pull request question

I have created a fork and from that one a pull request https://github.com/vcmi/vcmi/pull/268

It seems to me that everything I commit in my repository is added to this pull request. Am I understanding this well? If yes how can this be stopped?
 
     
Warmonger 
VCMI programmer


Age: 28
Joined: 07 Jun 2008
Posts: 1545
Location: Warsaw, Poland
Posted: 2017-01-28, 20:21   

Create another branch of 'develop' branch.
_________________
Think twice if you really need to send me private message. Use public forum for general questions.
DJ Warmonger blog
beegee wrote:
Warmonger, you are the best!
 
 
     
krs


Joined: 04 Sep 2012
Posts: 374
Posted: 2017-01-28, 22:47   

Ok so this is the solution, create another branch...

Now regarding the cause... I think I should have not made the initial pull request out from my "develop" branch in the first place, but from a feature branch instead, right?
 
     
krs


Joined: 04 Sep 2012
Posts: 374
Posted: 2017-01-29, 00:16   

So the pull request was created from my develop branch.

After/If the pull request is accepted, can I delete my remote develop branch and recreate one with the same name? Would this new branch be independent from the existing Pull request?
 
     
AVS 

Joined: 25 Feb 2011
Posts: 554
Location: Russia
Posted: 2017-01-29, 04:13   

Branches in your fork are your branches. You can anything with them.
 
     
Display posts from previous:   
Reply to topic
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum
Add this topic to your bookmarks
Printable version

Jump to:  

Powered by phpBB modified by Przemo © 2003 phpBB Group

Hosting provided by DigitalOcean
Page generated in 0.01 second. SQL queries: 13