Map editor

Next milestone achieved! Random generated map is looks playable as normal map.

I think it`s a time to think about merging part 1 aka PR 146.

Nice! Can’t wait :smiley:

Is there anything particular that needs to be revieved? Quite a huge commit.

There were already some regressions, mostly afraid of more. (New code - the format itself will be changed anyway also it will have more automatic tests.) There are not trivial changes in RMG, please look at them.

RMG works ok as far as I see. Ready for merge?

How about releasing editor tommorow? :unamused:

Please do :smiley:

As for branch probably yes. Some further work can be done in upstream.

I do not want to release editor until map format will be frozen - I do some changes often. PR 146 is only part 1 (2 more planned before 0.99)

But I can do release.

Well, we could say it’s only beta version for 0.98g.

I`ve added a release draft on GitHub.

Hm?

github.com/vcmi/vcmi_editor/releases

You have access to release draft. Please test attached binary before we release it to public.

Thanks.

Does this branch break savegame compatibility?

No such regressions were found. (However due to our architecture loading of old save will break new features until restart as map format depends on handlers state.)

That’s all I got so far :frowning: (with latest devlope recompiled).

When exactly it’s occur for you? Tried to remove mods?

PS: One problem of editor is that it’s doesn’t check if mod enabled or not in launcher and load everything. So it’s crashing when it’s unable to load JSON that “invalid” since loading not as permissive as in VCMI.

Will it give to log, which json file has errors?

I don’t think there is any logging, but I pretty sure that AVS going to make it work for all mods that VCMI can load.

Maybe it’s not good idea to load all mods including disabled?
After loading all mods editor will generate RMG map with all this stuff, fitting or not?

PS I have few mods disabled most of time, because they break game configs, when enabled with other noncompatible mods. They will surely break editor too:-)

I totally agree on it, but since it’s WiP that the way it currently works.

Editor don’t have RMG or any VCMI integration. It’s completely separate.

This is 99% wrong mod data. There is log file but for now in wrong place (in install path but not in user profile) it may have some more information.

As for mod enable/disable, it will be but I want it to be independent from game.

RMG (and some other VCMI_lib stuff) integration is also planned (but after map format stable release)