No I doubt there can be any problems, but decide to ask you as months ago when I asked Ivan why deb build have SDL1 used he said there may be reason related to Debian packages.
Anyway we donāt really support SDL1 as there several issues with fading so I doubt there will be worse problems than that. If you think itās okay then we may change debian rules: github.com/vcmi/vcmi/blob/develop/debian/rules
For the record, 0.97c builds fine in Debian. I was able to drop all four patches (as they were applied by you) and now the only difference between vcmi in Debian and yours is the default for autoCheckRepositories which is set to false in Debian because of privacy reasons. Thanks!
Yes. The only reason why it was disabled is because some distros (Ubuntu or Debian) at some point had somewhat broken SDL - missing libsdl2-ttf to be precise. Now according to their repositories everything is OK - Ubuntu LTS and later have all required packages & Debian jessie/sid have them as well.
josch, good to hear that
One note on patches - Iād prefer to avoid distro-specific patches if possible. Auto-check patch is reasonable but othervice - accepting patch into our repo is a better option. Donāt hesitate to ask if you want to change something in vcmi code.
FYI I found the cause of the bug and now Iām trying to find a solution. Itās pretty hard to get into terrain view pattern code, there should definitely be some sort of documentation
.dmp files are for Visual Studio. Unfortunatelly to use them you need Program Debug Database (.pdb) files associated with this exact build and I donāt bother about them annymore - neither use them. Unless anybody requests it, you can call .dmp obsolete feature.
This is also the position of Debian. Distro specific patches should be avoided if possible and only used if upstream absolutely refuses implementing a feature that is required by Debian policy or agreed to be necessary by Debian maintainers. Should any other issue come up, I will certainly file a pull request for them in the same way as I did for the last ones. Thanks!